HDDS-6125. Support Hugo 0.91.0. #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Create this PR to test against older version of Hugo. I was able to build the doc with Hugo 0.91.0 but not sure if the config file is backward compatible. |
adoroszlai
reviewed
Dec 20, 2021
There was a problem hiding this comment.
Thanks @jojochuang for reporting and fixing the issue. The patch works fine. Please consider some minor suggestions for improvement.
FYI, you can build with old Hugo (0.83.1) locally by running:
OZONE_PREFER_LOCAL_TOOL=false hadoop-ozone/dev-support/checks/docs.sh
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
|
Very nice. Thanks for the suggestion! |
adoroszlai
approved these changes
Dec 20, 2021
|
Thanks @jojochuang for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update config.yaml for Hugo to whitelist the environment variable OZONE_VERSION following the doc https://gohugo.io/about/security-model/
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6125
How was this patch tested?
Built locally