HDDS-6188: EC: Adapt java side native coder classes from hadoop. #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for taking this one on. As I went through the changes I have run into a few things that turned out to be something that I don't like in the original implementation either. LGTM, +!. |
added 4 commits
February 17, 2022 14:28
umamaheswararao
force-pushed
the
HDDS-6188
branch
from
24fe252
to
f7974c0
Compare
|
Thanks @fapifta for reviewing it. I have just rebased to make sure this is not introducing checkstyle issues. It's not introduced any new ones by my local run. You may want to approve above? |
fapifta
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Taken the Native Integration of Java side classes with fallback coder support from hadoop. When native coders not available, it will fallback to java.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6188
How was this patch tested?
There are tests added to verify the behavior and also integrated with Ozone EC IO streams.