HDDS-6440. Handle custom metadata (x-amz-meta) during put-object through S3 API. #3200
Conversation
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java
Show resolved
Hide resolved
| this.bucketName = bucketName; | ||
| this.name = keyName; | ||
| this.dataSize = size; | ||
| this.creationTime = Instant.ofEpochMilli(creationTime); |
There was a problem hiding this comment.
These should be set by OM?
There was a problem hiding this comment.
Also, nesting the constructors would help reduce code.
|
LGTM except for a couple of changes. I think limits are important here. Also, a minor nit. |
There was a problem hiding this comment.
Thanks @avijayanhwx for working on this. Looks good, except the minor duplication in constructor.
Note that keys in GDPR-enabled buckets are shown by ozone sh key info with metadata gdprEnabled: true. With this patch it is possible to set the same metadata on normal keys, which can be confusing.
"metadata" : {
"gdprEnabled" : "true"
},
| public OzoneKey(String volumeName, String bucketName, | ||
| String keyName, long size, long creationTime, | ||
| long modificationTime, ReplicationType type, | ||
| int replicationFactor, Map<String, String> metadata) { |
There was a problem hiding this comment.
I think we can omit this constructor (with type and factor), it should be deprecated in favor of ReplicationConfig right away.
| this.volumeName = volumeName; | ||
| this.bucketName = bucketName; | ||
| this.name = keyName; | ||
| this.dataSize = size; | ||
| this.creationTime = Instant.ofEpochMilli(creationTime); | ||
| this.modificationTime = Instant.ofEpochMilli(modificationTime); | ||
| this.replicationConfig = replicationConfig; |
There was a problem hiding this comment.
| this.volumeName = volumeName; | |
| this.bucketName = bucketName; | |
| this.name = keyName; | |
| this.dataSize = size; | |
| this.creationTime = Instant.ofEpochMilli(creationTime); | |
| this.modificationTime = Instant.ofEpochMilli(modificationTime); | |
| this.replicationConfig = replicationConfig; | |
| this(volumeName, bucketName, keyName, size, creationTime, | |
| modificationTime, replicationConfig); |
|
Thanks for the review, will address them! |
…nt/OzoneKey.java Co-authored-by: Doroszlai, Attila <6454655+adoroszlai@users.noreply.github.com>
…e into HDDS-6440-master
|
Hey @avijayanhwx， would you like to rebase the patch against the master？ |
|
/pending |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
|
@DaveTeng0 can you pick this one up? |
|
cc. kerneltime, adoroszlai Hey guys! I sync this branch with latest master and resolved all the merge conflicts in another PR. Please feel free to take a look at it if it's good and let me know any issue! |
What changes were proposed in this pull request?
Handle user defined metadata supplied through the s3 interface.
Reference - https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingObjects.html
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6440
How was this patch tested?
Manually tested put, head and copy object.
Added acceptance tests.