HDDS-5119. Recon file count by size page has incorrect data when keys are deleted #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fapifta
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Hi @dombizita thank you for working on these changes, the changes look good to me.
Let's wait a bit for @avijayanhwx if he has any further comments, but if he does not have the time, I will merge the changes later on.
|
We have synced with @avijayanhwx offline, based on that I am merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this change I fixed a bug in Recon. In the OMDBUpdatesHandler class when we process the events, if there were multiple actions on the same key the old value was not correct. The events are iterated upon before the actual Recon's OM copy DB is updated with these set of events. When we set the old value of the event's we set it from the DB, so after the second action the old value wasn't correct.
I changed it to get the old value from this batch if there were a previous event with the key. I did some refactoring in the TestOMDBUpdatesHandler and added a test case when we operate on the same entry in the same batch. In the OMDBUpdateEvent class I added the table to the hash method, as it was missing from there.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5119
How was this patch tested?
Added integration tests.