HDDS-6545. OzoneManagerUtils#getBucketLayout should not suppress bucket key lookup errors. #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Apr 6, 2022
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 6, 2022
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManagerUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 7, 2022 13:11
JyotinderSingh
force-pushed
the
HDDS-6545
branch
from
5455008
to
8211407
Compare
rakeshadr
reviewed
Apr 7, 2022
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzonePrefixPathImpl.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 7, 2022
...ration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java
Outdated
Show resolved
Hide resolved
rakeshadr
reviewed
Apr 8, 2022
There was a problem hiding this comment.
Thanks @JyotinderSingh for the updated patch. Added a minor imprv in test.
...ration-test/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisRequest.java
Show resolved
Hide resolved
rakeshadr
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OzoneManagerUtils#getBucketLayoutcatches the bucket key lookup errors that might occur and returns BucketLayout.DEFAULT.This behavior should be changed to throwing an error - otherwise it creates uncertainty.
This patch also reduces code duplication across the project for the
getBucketLayoutmethod.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6545
How was this patch tested?
Integration Tests.