Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-6617. Skip compile(11) for non-java changes #3324

Merged
merged 1 commit into from Apr 25, 2022

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Separate build and compile checks: compile is run only for Java and related changes. build is also needed to get the binary tarball for running acceptance tests.

https://issues.apache.org/jira/browse/HDDS-6617

How was this patch tested?

Updated test cases in selective_ci_checks.bats.

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2196208880

@adoroszlai adoroszlai self-assigned this Apr 20, 2022
@adoroszlai adoroszlai added enhancement New feature or request build Pull request that modifies the build process labels Apr 20, 2022
@kerneltime
Copy link
Contributor

LGTM superficially. Will this reduce time to run?

@adoroszlai
Copy link
Contributor Author

Will this reduce time to run?

  • will reduce total workflow runtime in specific cases by skipping unnecessary compile (11) runs as described in the PR
  • may reduce wall-clock time needed for a given workflow run (by not waiting for compile (11) to complete before starting acceptance)

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @adoroszlai LGTM.

@adoroszlai adoroszlai merged commit 497c7a4 into apache:master Apr 25, 2022
@adoroszlai adoroszlai deleted the HDDS-6617 branch April 25, 2022 08:21
@adoroszlai
Copy link
Contributor Author

Thanks @errose28 and @kerneltime for the review.

tanvipenumudy pushed a commit to tanvipenumudy/ozone that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Pull request that modifies the build process enhancement New feature or request
Projects
None yet
3 participants