HDDS-6894. EC: ReplicationManager - Add class to handle under-replication and form a command for a datanode #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
reviewed
Jun 24, 2022
...s/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ECContainerReplicaCount.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
thanks @umamaheswararao for the patch. i have few comments inline
...m/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECContainerHealthCheck.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
...m/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECContainerHealthCheck.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
.../java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationCommandCreator.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 27, 2022
...m/src/test/java/org/apache/hadoop/hdds/scm/container/states/TestECContainerReplicaCount.java
Outdated
Show resolved
Hide resolved
…tion and form a command for a datanode
umamaheswararao
force-pushed
the
HDDS-6894
branch
from
7cc7aed
to
b4d4ad5
Compare
There was a problem hiding this comment.
thanks @umamaheswararao for updating this patch . i have a few comment inline
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/hadoop/hdds/scm/container/states/TestECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/hadoop/hdds/scm/container/states/TestECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/hadoop/hdds/scm/container/states/TestECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Jun 28, 2022
.../src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Thanks @umamaheswararao for addressing my comments. LGTM, pending CI.
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jun 28, 2022
...s/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ECContainerReplicaCount.java
Outdated
Show resolved
Hide resolved
…. Also used decommissiononlyIndexes instead of dueToDecom check
…ded. We should let it go and check decom command as well. They are not exclusive checks now.
There was a problem hiding this comment.
thanks @umamaheswararao for updating. i have few comment inline, PTAL!
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
...rc/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java
Show resolved
Hide resolved
|
LGTM +1! pending clean CI |
JacksonYao287
approved these changes
Jun 29, 2022
…rate API. Which should cover LegacyRM as well.
|
Thanks @sodonnel @adoroszlai @JacksonYao287 for the great reviews. |
duongkame
pushed a commit
to duongkame/ozone
that referenced
this pull request
Aug 16, 2022
HDDS-6894. EC: ReplicationManager - Add class to handle under-replication and form a command for a datanode (apache#3542) (cherry picked from commit 6537056) Change-Id: I8153852674fb54e838d71cc5dd4a452611528b2c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a class to handle the under replication processing and forming the reconstruction command.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6894
How was this patch tested?
Added the tests.