HDDS-6943. Reject property change requests on link buckets #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
changed the title
ayushtkn
approved these changes
Jun 26, 2022
rakeshadr
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
+1 LGTM, thanks @adoroszlai for the contribution. I will merge it shortly.
|
Thanks @ayushtkn for the review, @rakeshadr for reviewing and merging this. |
duongkame
pushed a commit
to duongkame/ozone
that referenced
this pull request
Aug 16, 2022
apache#3546) (cherry picked from commit 178103b) Change-Id: I1e75a35717ec152f620bae689d4944349de745a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Trying to set quota on a link bucket converts it to a regular bucket, because the source volume/bucket information is lost at OM during request processing. This could be fixed similarly to HDDS-6941. However, quota, layout, and other properties are not applicable to links. So this PR proposes to reject property change requests on link buckets.
https://issues.apache.org/jira/browse/HDDS-6943
How was this patch tested?
Added unit test:
https://github.com/adoroszlai/hadoop-ozone/runs/7040743390#step:5:1962
and acceptance test:
https://github.com/adoroszlai/hadoop-ozone/runs/7041017030#step:5:138