HDDS-6948. MultiTenantAccessAuthorizerRangerPlugin#deletePolicyByName should log and exit if getAccessPolicyByName returns null #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yName should log and exit if getAccessPolicyByName returns null
smengcl
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Thanks @ghuangups for the improvement!
Note once RangerClient work is done this whole class will very likely be removed (as RangerClient will handle the request logic and we don't need to manually handle this part in Ozone anymore), during HDDS-6909 or after it.
smengcl
changed the title
smengcl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check whether return policy is null. If so, we should log and exit instead of still trying to delete the policy.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6948
How was this patch tested?
N/A