HDDS-7048. EC: Add debug logging with exception info when stripe write failed #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
Show resolved
Hide resolved
|
|
||
| String failedStreamsString = IntStream.range(1, | ||
| numDataBlks + numParityBlks + 1) | ||
| .mapToObj(index -> failedStreamIndexMap.containsKey(index) |
There was a problem hiding this comment.
change P -> S . meaning "Success"
adoroszlai
changed the title
...t/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java
Show resolved
Hide resolved
| @@ -203,6 +206,25 @@ private void encodeAndWriteParityCells() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| private void logStreamError(List<ECBlockOutputStream> failedStreams, | |||
| String operation) { | |||
| Set<Integer> failedStreamIndexMap = | |||
There was a problem hiding this comment.
You may want to change this variable name to set.
| .mapToObj(index -> failedStreamIndexMap.contains(index) | ||
| ? "F" : "S") | ||
| .collect(Collectors.joining(" ")); | ||
| LOG.error("{} failed: {}", operation, failedStreamsString); |
There was a problem hiding this comment.
In EC we will actually proceed by closing current blockGroup. Should we change the log level to warn instead?
...t/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java
Show resolved
Hide resolved
| * Get the Replication Index. | ||
| * @return replicationIndex | ||
| */ | ||
| public int getReplicationIndex() { |
There was a problem hiding this comment.
can this be in default scope?
There was a problem hiding this comment.
The class we are accessing from is not in the same package
There was a problem hiding this comment.
Git it. This is ok.
umamaheswararao
approved these changes
Jul 29, 2022
duongkame
pushed a commit
to duongkame/ozone
that referenced
this pull request
Aug 16, 2022
… stripe write failed (apache#3625) Change-Id: I364a38c34e6f554f58cdbbc1e5ffa9c3a19d3497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding debug Logs for EC Stripe Write Failures
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7048
How was this patch tested?
Logging Changes