HDDS-7047. Add Recon to ozone-topology sample compose environment #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I4d555a1f123175ce7c173355fa128d497182a390
Change-Id: I822cbeab897707c5fc34e74ba0424003f3387b22
adoroszlai
reviewed
Aug 1, 2022
| env_file: | ||
| - docker-config | ||
| environment: | ||
| OZONE-SITE.XML_ozone.replication: ${OZONE_REPLICATION_FACTOR:-1} |
There was a problem hiding this comment.
OZONE_REPLICATION_FACTOR lets us use scalable environments (ozone, ozone-ha, etc.) with a single datanode by default, and scale to 3 if needed. It is not applicable to the ozone-topology environment. With a fixed set of 6 datanodes it is configured as:
So we can remove this extra config:
Suggested change
| OZONE-SITE.XML_ozone.replication: ${OZONE_REPLICATION_FACTOR:-1} |
There was a problem hiding this comment.
Thanks for explaining this, I updated my patch.
smengcl
reviewed
Aug 2, 2022
hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml
Outdated
Show resolved
Hide resolved
Change-Id: I9645f18f4bb1e832ca02fdbf5fa8b169d963d143
smengcl
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I added Recon as a service to the
compose/ozone-topologyenvironment. I also added the Recon robot tests to the test.sh in the ozone-topology folder.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7047
How was this patch tested?
I tested it in the
compose/ozone-topologyenvironment via docker and run the test.sh locally.https://github.com/dombizita/ozone/actions/runs/2769844964