HDDS-7108. Include supported EC data-parity combinations in error message #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@umamaheswararao @kerneltime Feel free to take a look if the added message helps! Thanks! |
|
LGTM, please address failing CI tests |
sure! looking |
DaveTeng0
changed the title
DaveTeng0
changed the title
kerneltime
approved these changes
Aug 10, 2022
kerneltime
approved these changes
Aug 10, 2022
adoroszlai
changed the title
|
Thank you, @DaveTeng0 for this patch. |
adoroszlai
reviewed
Aug 20, 2022
Comment on lines
+65
to
+68
| "Invalid data-parity replication config " + | ||
| "for type " + replicationConfig.getReplicationType() + | ||
| " and replication " + replication + "." + | ||
| " Supported data-parity are 3-2,6-3,10-4"); |
There was a problem hiding this comment.
Sorry for the late review.
This exception may be thrown for non-EC replication config, too, in which case data-parity is not applicable. The message should be different based on replication type.
CLI commands validate RATIS replication factor before reaching this check, but Java code using RpcClient#createKey directly could encounter this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Need proper error message on console output when incorrect replication data-parity config is passed
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7108
How was this patch tested?
Manually test from developer machine