Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-7134. NPE when Ranger client throws RangerServiceException without Status. #3689

Merged
merged 2 commits into from Aug 19, 2022

Conversation

errose28
Copy link
Contributor

What changes were proposed in this pull request?

RangerClientMultiTenantAccessController#decodeRSEStatusCodes assumes the provided RangerServiceException will have a non-null status. However, Looking at the constructors for the class this may not always be true, and we have seen exceptions will null statuses during testing.

What is the link to the Apache JIRA

HDDS-7134

How was this patch tested?

N/A

@errose28 errose28 requested a review from smengcl August 17, 2022 22:50
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @errose28 for the patch. Would you fix the checkstyle?

@errose28
Copy link
Contributor Author

Oops should be fixed now.

Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

@errose28
Copy link
Contributor Author

Thanks for the review @smengcl

@errose28 errose28 merged commit 5d8573a into apache:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants