HDDS-7255. Add metrics for container reports events #3936
Conversation
|
Will these metrics be exposed via prometheus? |
Using JMX endpoint, its exposed as below, Using prometheus, its exposed, but coming only for FCR, But not coming for ICR as metric name is created based on class name, this is old problem and will be tracked as part of JIRA https://issues.apache.org/jira/browse/HDDS-7464 |
|
@ChenSammi @nandakumar131 Plz review |
| @@ -490,7 +490,8 @@ public final class ScmConfigKeys { | |||
| public static final String OZONE_SCM_EVENT_CONTAINER_REPORT_THREAD_POOL_SIZE = | |||
| OZONE_SCM_EVENT_PREFIX + "ContainerReport.thread.pool.size"; | |||
| public static final int OZONE_SCM_EVENT_THREAD_POOL_SIZE_DEFAULT = 10; | |||
|
|
|||
| public static final int OZONE_SCM_EVENT_REPORT_QUEUE_WAIT_DEFAULT = 60000; | |||
| public static final int OZONE_SCM_EVENT_REPORT_EXEC_WAIT_DEFAULT = 120000; | |||
There was a problem hiding this comment.
OZONE_SCM_EVENT_REPORT_EXEC_WAIT_DEFAULT -> OZONE_SCM_EVENT_REPORT_LONG_EXEC_DEFAULT?
Also please add some comment about the time unit.
There was a problem hiding this comment.
Add comment, its in milli second
There was a problem hiding this comment.
Suggest to add threshold in the name, that is
OZONE_SCM_EVENT_REPORT_QUEUE_WAIT_DEFAULT -> OZONE_SCM_EVENT_REPORT_QUEUE_WAIT_THRESHOLD_DEFAULT
OZONE_SCM_EVENT_REPORT_EXEC_WAIT_DEFAULT -> OZONE_SCM_EVENT_REPORT_EXEC_WAIT_THRESHOLD_DEFAULT
| OZONE_SCM_EVENT_REPORT_QUEUE_WAIT_DEFAULT); | ||
| long execWaitThreshold = ozoneConfiguration.getInt( | ||
| ScmUtils.getContainerReportConfPrefix() + ".execute.wait.threshold", | ||
| OZONE_SCM_EVENT_REPORT_EXEC_WAIT_DEFAULT); |
There was a problem hiding this comment.
What will be the full name of these two property?
There was a problem hiding this comment.
added in comment
There was a problem hiding this comment.
Could you add the comments in StorageContainerManager.java too?
|
LGTM + 1. Thanks @sumitagrawl. |
What changes were proposed in this pull request?
Added metrics for
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7255
How was this patch tested?
Tested using Unit case and count is verified