HDDS-4565. [FSO]Delete : quotaReleased on directory deletion should consider all sub paths #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsider all sub paths
|
@nandakumar131 @ChenSammi Plz review |
sadanand48
reviewed
Nov 16, 2022
There was a problem hiding this comment.
Thanks @sumitagrawl for working on this, This PR provides fix for non-FSO buckets, I think we should remove FSO tag from title and jira.
| @@ -1242,24 +1239,13 @@ public List<BlockGroup> getPendingDeletionKeys(final int keyCount) | |||
| if (kv != null) { | |||
| RepeatedOmKeyInfo infoList = kv.getValue(); | |||
| for (OmKeyInfo info : infoList.cloneOmKeyInfoList()) { | |||
There was a problem hiding this comment.
for loop can be avoided here, we can use list.addAll() . currrentCount will be size of the list.
| for (DeletedKeys bucketWithDeleteKeys : bucketDeletedKeysList) { | ||
| String volumeName = bucketWithDeleteKeys.getVolumeName(); | ||
| String bucketName = bucketWithDeleteKeys.getBucketName(); | ||
| OmBucketInfo omBucketInfo = getBucketInfo(omMetadataManager, volumeName, |
There was a problem hiding this comment.
Since we are updating bucketTable metadata here , bucket lock needs to be acquired, else someone can delete the bucket.
| .collect(Collectors.toList()).size() == 3; | ||
| .mapToInt(e -> e.getKeyLocationVersions().stream() | ||
| .map(OmKeyLocationInfoGroup::getLocationList). | ||
| mapToInt(List::size).sum()).sum() == 3; | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Can we also add a unit test to verify updation of the usedBytes and namespace after key cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While delete keys in background service for recursive cleanup, cleanup of key's space and its namespace is added in purge of keys.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4565
How was this patch tested?
Test is done considering below scenario: