New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-7253. Fix exception when '/' in key name #4038
Conversation
100x ITestOzoneContractMkdir: https://github.com/kaijchen/ozone/actions/runs/3609358975 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the regression in #3774 has been fixed.
@sadanand48 Do you want to take another look?
Thanks @xichen01 for the update. |
Looks like |
100x @xichen01, sometimes after a rename, the old keyName is still in table:
|
Seems this issue exists before this PR, but with a smaller chance (1/300 vs 2/100). The problem is probably due to |
* master: (110 commits) HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys (apache#3987) HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id (apache#3862) HDDS-7555. Upgrade Ratis to 2.4.2-8b8bdda-SNAPSHOT. (apache#4028) HDDS-7541. FSO recursive delete directory with hierarchy takes much time for cleanup (apache#4008) HDDS-7581. Fix update-jar-report for snapshot (apache#4034) HDDS-7253. Fix exception when '/' in key name (apache#4038) HDDS-7579. Use Netty 4.1.77 for consistency (apache#4031) HDDS-7562. Suppress warning about long filenames in tar (apache#4017) HDDS-7563. Add a handler for under replicated Ratis containers in RM (apache#4025) HDDS-7497. Fix mkdir does not update bucket's usedNamespace (apache#3969) HDDS-7567. Invalid entries in LICENSE (apache#4020) HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI (apache#4026) HDDS-7540. Let reusable workflow inherit secrets (apache#4012) HDDS-7568. Bump copyright year in NOTICE (apache#4018) HDDS-7394. OM RPC FairCallQueue decay decision metrics list caller username in the metric (apache#3878) HDDS-7510. Recon: Return number of open containers in `/clusterState` endpoint (apache#3989) HDDS-7561. Improve setquota, clrquota CLI usage (apache#4016) HDDS-6615. EC: Improve write performance by pipelining encode and flush (apache#3994) HDDS-7554. Recon UI should show DORMANT in pipeline status filter (apache#4010) HDDS-7540. Separate scheduled CI from push/PR workflows (apache#4004) ...
This is a resubmitted MR, the old one is #3774
This MR fixes an issue that may be making ITestOzoneContractMkdir flaky.
What changes were proposed in this pull request?
Fix exception when '/' in key name
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7253
How was this patch tested?
How to reproduce the bug
ls
command for keys containing '/'before this commit
[root@Linux /root/ozone]% bin/ozone fs -ls ofs://localhost/s3v/testbucket/ Found 1 items drwxrwxrwx - root root 0 2022-09-19 14:11 ofs://localhost/s3v/testbucket/dir1 [root@Linux /root/ozone]% bin/ozone fs -ls ofs://localhost/s3v/testbucket/dir1 ls: `ofs://localhost/s3v/testbucket/dir1': No such file or directory
after this commit
for
mv
,mkdir
,count
command for keys containing '/'before this commit
after this commit