Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-7371. Create properties for all dependency versions #4059

Merged
merged 2 commits into from Dec 16, 2022

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Move all dependency version definition to properties in root POM. This allows overriding the dependency's version for each build.

https://issues.apache.org/jira/browse/HDDS-7371

How was this patch tested?

Verified that all dependency versions are defined via properties, only enforcer rules have non-property-based <version> tags:

$ rg '<version>' | grep -Fv -e '1.3.0-SNAPSHOT' -e '<version>${'
pom.xml:                <version>[3.0.2,)</version>
pom.xml:                <version>[1.8,)</version>

Verified that dependency tree is same as for master:

$ git checkout master
$ mvn -Dorg.slf4j.simpleLogger.showDateTime=false -B --no-transfer-progress dependency:tree > dep.master
$ git checkout HDDS-7371
$ mvn -Dorg.slf4j.simpleLogger.showDateTime=false -B --no-transfer-progress dependency:tree > dep.HDDS-7371
$ diff -uw dep.master dep.HDDS-7371
--- dep.master	2022-12-08 10:08:39.198215059 +0100
+++ dep.HDDS-7371	2022-12-08 10:08:41.990179382 +0100
@@ -5080,52 +5080,52 @@
 [INFO] ------------------------------------------------------------------------
 [INFO] Reactor Summary for Apache Ozone Main 1.3.0-SNAPSHOT:
 [INFO] 
-[INFO] Apache Ozone Main .................................. SUCCESS [  0.234 s]
-[INFO] Apache Ozone HDDS .................................. SUCCESS [  0.293 s]
+[INFO] Apache Ozone Main .................................. SUCCESS [  0.211 s]
+[INFO] Apache Ozone HDDS .................................. SUCCESS [  0.316 s]
...

@adoroszlai adoroszlai self-assigned this Dec 8, 2022
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Dec 8, 2022
@@ -62,6 +62,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
</organization>

<properties>
<hadoop2.version>2.7.3</hadoop2.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This might be a good PR to sort the list :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to do aesthetic changes separately?

@kerneltime
Copy link
Contributor

The change looks good, will check all the pom files locally and give it a LGTM. Thank you @adoroszlai

@adoroszlai
Copy link
Contributor Author

@kerneltime have you had a chance to take another look?

@adoroszlai
Copy link
Contributor Author

Thanks @kerneltime for the review.

Copy link
Contributor

@nishitpatira nishitpatira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nishitpatira pushed a commit to nishitpatira/ozone that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Pull request that modifies the build process
Projects
None yet
3 participants