New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-7371. Create properties for all dependency versions #4059
Conversation
@@ -62,6 +62,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs | |||
</organization> | |||
|
|||
<properties> | |||
<hadoop2.version>2.7.3</hadoop2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This might be a good PR to sort the list :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to do aesthetic changes separately?
The change looks good, will check all the pom files locally and give it a LGTM. Thank you @adoroszlai |
@kerneltime have you had a chance to take another look? |
Thanks @kerneltime for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this pull request?
Move all dependency version definition to properties in root POM. This allows overriding the dependency's version for each build.
https://issues.apache.org/jira/browse/HDDS-7371
How was this patch tested?
Verified that all dependency versions are defined via properties, only enforcer rules have non-property-based
<version>
tags:Verified that dependency tree is same as for
master
: