New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-7994. Expose information via the ClusterState endpoint on keys and Directories marked for deletion #4406
Conversation
…o the DeletedTable.
@jojochuang @ChenSammi @devmadhuu @dombizita can you please take a look! |
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java
Show resolved
Hide resolved
@sumitagrawl can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArafatKhan2198 Count of deleted keys is one of sub-part of features which is under analysis phase, as part of that, it need expose Recon Insight for deletedTable, deletedDirectoryTable, and other metadata, to show data in progress of deletion. So there can be changes in interface and details to be exposed.
I think we can hold this till that is designed. @devmadhuu is working over this.
...-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/ClusterStateResponse.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArafatKhan2198 LGTM, plz add testcase for deletedDir Count also
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArafatKhan2198 Thanks for working, LGTM +1
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Merging it
Merged. Thanks @sumitagrawl for the review! |
What changes were proposed in this pull request?
ClusterStateEndpoint
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7994
How was this patch tested?
Unit Testing