HDDS-8276. EC file checksum calculation fails with topology-aware read enabled #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test topology aware read, too * test all file sizes with each set of missing nodes
sodonnel
approved these changes
Mar 29, 2023
|
Thanks @sodonnel for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ECFileChecksumHelper#getChunkInfoscopies the original EC pipeline and limits nodes to specific replicas. However, the list of "nodes in order", used for topology-aware read, still contains all original nodes. Thus it may happen that read is attempted from the wrong node.This patch updates "nodes in order" in the copy to reflect the same set of nodes as the unordered one.
Also remove a stray placeholder from the error message:
Fail to get block checksum for ... checksum combine mode : {}COMPOSITE_CRChttps://issues.apache.org/jira/browse/HDDS-8276
How was this patch tested?
Updated the integration test
TestOzoneFileChecksumto cover both topology-aware and regular read.https://github.com/adoroszlai/hadoop-ozone/actions/runs/4553955626