HDDS-8239. RATIS_DATASTREAM port compatibility issue #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DatanodeDetails. Change-Id: Ie2e20f609b4cbc503eb005eb753d0f07a1707370
Change-Id: I4b5ee06f823764c99a4c4014829686bc3e69010c
Change-Id: Ie8af9aeb1a9f81fead4b6cc67890225eb04a0065
Change-Id: Ibdde6f40388f62642afa26d180d4b5f42aa0142d
Change-Id: Ifc91f2a5a2308778e125993d137a5684bacac47f
Change-Id: I86a065562f3cd1667904f7682514de9b8131a2da
Change-Id: I37f2f002ed44b2a182b6fa1c7aa24a5634249b63
Change-Id: I9429c1a22586d3ae9289f13f684dc8a9cb1eb4ba
adoroszlai
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks @dombizita for the patch, and for the additional work for extracting it from HDDS-7817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Based on previous discussions we found out that the
RATIS_DATASTREAMport inDatanodeDetailssuffers from incompatibility problem and we decided to add a HDDS layout version asRATIS_DATASTREAM_PORT_IN_DATANODEDETAILSto handle that. I created aBelongsToHDDSLayoutVersionannotation and used it to annotate theRATIS_DATASTREAMport with it. In thegetDatanodeDetailsYaml()when we are adding the ports I checked if the port has this annotation and checked if the current layout version is smaller than the layout version of the annotation. In that case I am not writing the ports in to the DatanodeDetails yaml file.As not the
DATANODE_SCHEMA_V3is the latest HDDS layout version anymore I changed some tests to not require exact match with the versions in theTestDatanodeUpgradeToSchemaV3.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8239
How was this patch tested?
CI on my fork: https://github.com/dombizita/ozone/actions/runs/4558939757