HDDS-8346. ContainerBalancer should move only CLOSED replicas #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
approved these changes
Apr 12, 2023
adoroszlai
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Container Balancer checks if a container is CLOSED, but does not check whether the replica being moved is also CLOSED. This should be checked to be consistent with ReplicationManager and avoid moving any un CLOSED replicas.
Change made: When selecting candidate containers (eligible for being moved because they satisfy selection criteria) from a source DN, filter out containers whose replica on that source is non CLOSED.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8346
How was this patch tested?
Added UT.
Draft while waiting for CI in my fork: https://github.com/siddhantsangwan/ozone/actions/runs/4678046422