Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-8768. Update cross-compatibility test for 1.3.0 release #4836

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Run cross-compatibility test for both 1.3.0 (already released) and 1.4.0 (built from source).

https://issues.apache.org/jira/browse/HDDS-8768

How was this patch tested?

CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5191899874

@adoroszlai adoroszlai self-assigned this Jun 6, 2023
@adoroszlai adoroszlai added the test label Jun 6, 2023
@adoroszlai adoroszlai requested a review from errose28 June 6, 2023 20:15
@adoroszlai adoroszlai changed the title HDDS-8768. Update cross-compatibility for 1.3.0 HDDS-8768. Update cross-compatibility test for 1.3.0 release Jun 8, 2023
@captainzmc
Copy link
Member

Thanks @adoroszlai for the patch. The change looks good.
Does test_ec_cross_compatibility need to be modified?

@adoroszlai
Copy link
Contributor Author

Does test_ec_cross_compatibility need to be modified?

Good point, I was not aware of this custom test. I think this will need a bigger change, because the way it is implemented does not scale to new versions. Created HDDS-8819 for this.

Copy link
Member

@captainzmc captainzmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's merge this.

@captainzmc captainzmc merged commit b4ea2fb into apache:master Jun 12, 2023
18 checks passed
@adoroszlai adoroszlai deleted the HDDS-8768 branch June 12, 2023 10:23
@adoroszlai
Copy link
Contributor Author

Thanks @captainzmc for reviewing and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants