HDDS-8813. Prepare for dynamic config in ReplicationManager #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhantsangwan
approved these changes
Jun 12, 2023
| long intervalInMillis) { | ||
| super(replicationManager, intervalInMillis); | ||
| UnderReplicatedProcessor(ReplicationManager replicationManager, | ||
| Supplier<Duration> interval) { |
There was a problem hiding this comment.
What's the reason for passing in a Supplier?
There was a problem hiding this comment.
If we simply pass the current value (long or Duration), an updated config value will not be reflected in the (Under|Over)ReplicatedProcessor. Alternatively, we could define an abstract method for the interval in UnhealthyReplicationProcessor, and override it in the subclasses, returning the current value of ReplicationManager's (under|over)ReplicatedInterval.
|
Thanks @siddhantsangwan for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
ReplicationManagerand related classes to prepare for dynamic reconfigurability. Avoid storing config in member variables.https://issues.apache.org/jira/browse/HDDS-8813
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5235703783