HDDS-8835. ReplicationManager: Fix metrics to work with new RM #4882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change is to tidy up the metrics in ReplicationManager metrics. Some of the legacy metrics are no longer valid in the new RM, and the naming was inconsistent between the old Ratis metrics and EC metrics.
The new metrics after this change look like the following:
There are some quite large changes as a result of renaming some getting and setter methods after changing the metric names, but the change is split into separate commits to make it easier to review.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8835
How was this patch tested?
Some tests were modified, but this was mostly validated manually to produce the results above, by create containers and stopping and starting some nodes.