Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-8850. ReplicationManager: Add metrics for partial replication / reconstruction and cluster limit #4917

Merged
merged 5 commits into from Jun 17, 2023
Merged

HDDS-8850. ReplicationManager: Add metrics for partial replication / reconstruction and cluster limit #4917

merged 5 commits into from Jun 17, 2023

Conversation

sodonnel
Copy link
Contributor

What changes were proposed in this pull request?

Add additional metrics to ReplicationManagerMetrics:

  • PendingReplicationClusterLimitReached - incremented if the cluster wide limit has been reached.
  • Partial Reconstruction metrics to indicate when EC reconstruction is not able to recover all the indexes, only some of them.
  • Partial replication metrics for EC decommission / maintenance replicas and Ratis replication.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8850

How was this patch tested?

Tests modified to check the new metrics.

adoroszlai
adoroszlai approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sodonnel for the patch, LGTM.

@adoroszlai adoroszlai merged commit b3b3415 into apache:master Jun 17, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sodonnel @adoroszlai