HDDS-9237. Enable lock order fairness for striped locks. #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Thanks @duongkame for the patch. LGTM, but test should be renamed to get executed.
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/utils/SimpleStripedTest.java
Outdated
Show resolved
Hide resolved
Thanks @adoroszlai. Test is fixed now. |
adoroszlai
approved these changes
Sep 11, 2023
kerneltime
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-8765 uses Guava's Striped to implement striped locks in OM. For now, Striped doesn't allow creating striped locks with a custom fairness order. Details are in #4885.
There's a open issue and a PR in Guava to address that, but looks like they're not reviewed by Guava devs for a long time.
This PR implements a factory of
com.google.common.util.concurrent.Stripedwhich uses reflection to create Striped locks with fair order policy.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9237
How was this patch tested?
Unit-tested.