HDDS-6154. Update NodeManagerInsight with the correct node metrics #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Oct 15, 2023
There was a problem hiding this comment.
Thanks @VarshaRaviCV for working on this.
I would like to suggest creating these MetricDisplay instances in a nested loop (over operational state and health state) instead of manually enumerating all of them. This will reduce future work required for adapting to related changes. It will also take care of ordering these metrics logically (e.g. "stale" should come before "dead", "entering maint" should come before "in maint").
adoroszlai
reviewed
Oct 25, 2023
hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/scm/NodeManagerInsight.java
Outdated
Show resolved
Hide resolved
|
Thanks @VarshaRaviCV for updating the patch. @sodonnel please review. |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updating the NodeManagerInsight to reflect the correct node metrics
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6154
How was this patch tested?
Docker-compose environment with command ozone insight metrics scm.node-manager
sh-4.2$ ozone insight metrics scm.node-manager Metrics forscm.node-manager` (SCM Datanode management related information.)Node counters
in_service healthy Nodes: 3
in_service stale Nodes: 0
in_service dead Nodes: 0
decommissioning healthy Nodes: 0
decommissioning stale Nodes: 0
decommissioning dead Nodes: 0
decommissioned healthy Nodes: 0
decommissioned stale Nodes: 0
decommissioned dead Nodes: 0
entering_maintenance healthy Nodes: 0
entering_maintenance stale Nodes: 0
entering_maintenance dead Nodes: 0
in_maintenance healthy Nodes: 0
in_maintenance stale Nodes: 0
in_maintenance dead Nodes: 0
HB processing stats
HB processed: 26
HB processing failed: 0`