HDDS-8201. Migrated TestOmSnapshotFileSystem tests to JUnit5. #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantpogde
approved these changes
Nov 10, 2023
swamirishi
requested changes
Nov 10, 2023
...zone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotFileSystem.java
Outdated
Show resolved
Hide resolved
hemantk-12
force-pushed
the
HDDS-8201
branch
from
9349e0e
to
7b77f98
Compare
aswinshakil
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Thanks for the patch @hemantk-12. LGTM+1. Minor nit inline.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @prashantpogde @aswinshakil and @swamirishi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change is to migrate TestOmSnapshotFileSystem tests from JUnit-4 to JUnit-5. Changed the cluster setup to only once at class level as suggested in #4740.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8201
How was this patch tested?
Ran the unit test locally and workflow run. Test run time after the change around 80 secs.