Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-9890. Fix comment typo in OmMetadataManagerImpl #5763

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jianghuazhu
Copy link
Contributor

What changes were proposed in this pull request?

In OmMetadataManagerImpl, there are some wrong symbols, the purpose of this PR is to fix them.
Details: HDDS-9890

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9890

How was this patch tested?

This is a change related to documentation and does not require too much testing. Just keep the unit tests passing.

@jianghuazhu
Copy link
Contributor Author

https://github.com/jianghuazhu/ozone/actions/runs/7164919925
Here is the ci/cd of the fork branch, it looks normal.
Can you help review this PR, @adoroszlai @hemantk-12 .
Thanks.

@adoroszlai
Copy link
Contributor

Thanks @jianghuazhu for spotting the typo. Please consider #5557 (comment)

@jianghuazhu
Copy link
Contributor Author

Thanks @adoroszlai for the comment and review.
The problem described by this jira must be fixed, so I created a separate jira and tried to solve it.
Now I need to wait for more similar questions, right?

@jianghuazhu
Copy link
Contributor Author

Thanks @kerneltime .

@hemantk-12
Copy link
Contributor

hemantk-12 commented Dec 12, 2023

@jianghuazhu can you please rebase your fork branch?

@adoroszlai adoroszlai changed the title HDDS-9890. Fix wrong characters in OmMetadataManagerImpl HDDS-9890. Fix comment typo in OmMetadataManagerImpl Dec 12, 2023
@adoroszlai adoroszlai changed the title HDDS-9890. Fix comment typo in OmMetadataManagerImpl HDDS-9890. Fix comment typo in OmMetadataManagerImpl Dec 12, 2023
@jianghuazhu
Copy link
Contributor Author

Thanks @hemantk-12 for the comment and review.
I'll update soon.

@adoroszlai adoroszlai merged commit 696ae77 into apache:master Dec 12, 2023
16 of 18 checks passed
@adoroszlai
Copy link
Contributor

Thanks @jianghuazhu for the patch. Since it's a trivial comment change, I think we can merge it without CI.

@jianghuazhu
Copy link
Contributor Author

Thanks @adoroszlai .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants