HDDS-10173. findbugs: Random object used only once in TestBlockOutputStreamCorrectness #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
changed the title
|
Thanks @adoroszlai for the fix. |
|
Thanks @nandakumar131 for reviewing and merging this. |
smengcl
pushed a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Feb 7, 2024
…StreamCorrectness. (apache#6131) (cherry picked from commit 49df646)
smengcl
added a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Feb 7, 2024
…ckOutputStreamCorrectness. (apache#6131)" This reverts commit 8dc1a67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Background: Spotbugs 4 finds more problems than Spotbugs 3, which we currently use. Upgrade to Spotbugs 4 is required for migration to Java 11+. This PR fixes a warning which is new to Spotbugs 4.
Refactor
TestBlockOutputStreamCorrectnessto avoid the need fornew Random.Also parameterize the test, to exercise both single-byte and array write path.
https://issues.apache.org/jira/browse/HDDS-10173
How was this patch tested?
Tested with Spotbugs 4:
CI:
https://github.com/adoroszlai/ozone/actions/runs/7716000984/job/21032183070#step:5:999