Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-10416. Move HA-specific settings to MiniOzoneHAClusterImpl.Builder #6275

Merged
merged 2 commits into from
Feb 28, 2024
Merged

HDDS-10416. Move HA-specific settings to MiniOzoneHAClusterImpl.Builder #6275

merged 2 commits into from
Feb 28, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Several HA-specific settings are defined in MiniOzoneCluster, but the non-HA implementation ignores them. They should be moved to MiniOzoneHAClusterImpl.Builder.

Some tests used to set HA-specific properties while creating non-HA cluster, these are removed.

https://issues.apache.org/jira/browse/HDDS-10416

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/8048774223

@adoroszlai adoroszlai added test code-cleanup Changes that aim to make code better, without changing functionality. labels Feb 26, 2024
@adoroszlai adoroszlai self-assigned this Feb 26, 2024
nandakumar131
nandakumar131 reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all the change looks good to me.
Is there any reason for reordering the setNumDatanodes method call while building MiniOzoneCluster?

@adoroszlai
Copy link
Contributor Author

Is there any reason for reordering the setNumDatanodes method call while building MiniOzoneCluster?

Yes. setNumDatanodes returns non-HA builder (MiniOzoneCluster.Builder), HA-specific methods cannot be called on that.

@nandakumar131
Copy link
Contributor

Thanks for the clarification @adoroszlai.

@nandakumar131 nandakumar131 merged commit f440654 into apache:master Feb 28, 2024
26 checks passed
@adoroszlai adoroszlai deleted the HDDS-10416 branch February 28, 2024 08:08
@adoroszlai
Copy link
Contributor Author

Thanks @nandakumar131 for reviewing and merging this.

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 15, 2024
@adoroszlai @jojochuang
HDDS-10416. Move HA-specific settings to MiniOzoneHAClusterImpl.Build…
0760aae 
…er (apache#6275)

(cherry picked from commit f440654)
Change-Id: Ieb1e5e37560459462eafdf8edb27a2a90e559885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandakumar131 nandakumar131 nandakumar131 left review comments

Assignees

@adoroszlai adoroszlai

Labels
code-cleanup Changes that aim to make code better, without changing functionality. test
Projects
None yet
Milestone
No milestone
2 participants
@adoroszlai @nandakumar131