HDDS-10425. Increase OM transaction index for non-Ratis based on existing Ratis transactionInfoTable #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase OM transaction index for non-Ratis based on existing Ratis transactionInfoTable
|
@ChenSammi @hanishakoneru Could you help review if you have the time ? Thanks ! |
Galsza
reviewed
Feb 27, 2024
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
ChenSammi
approved these changes
Feb 28, 2024
|
@whbing thanks for the patch, LGTM +1 |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
…ting Ratis transactionInfoTable (apache#6281) (cherry picked from commit 4da5a64) Change-Id: Ibdad3f657cb5b481c1ec2655473b9df48011d8c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ObjectIDs duplicate when non-Ratis OM start from an existing Ratis transactionInfoTable.
Transaction index should increase incrementally based on the existing transactionInfoTable for non-Ratis rather than from 0.
This approach will facilitate the migration from Ratis to non-Ratis scenarios seamlessly.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10425
How was this patch tested?
manual tests.
For origin ratis transactionInfoTable
bin/ozone debug ldb --db=/home/hadoop/cluster-data/ozonedata/om/db/om.db scan --cf=transactionInfoTable { "#TRANSACTIONINFO": { "term" : 1, "transactionIndex" : 9 }(1) without pr
migrate to non-ratis
bin/ozone debug ldb --db=/home/hadoop/cluster-data/ozonedata/om/db/om.db scan --cf=transactionInfoTable { "#TRANSACTIONINFO": { "term" : -1, "transactionIndex" : 3 }(2) with pr
migrate to non-ratis
bin/ozone debug ldb --db=/home/hadoop/cluster-data/ozonedata/om/db/om.db scan --cf=transactionInfoTable { "#TRANSACTIONINFO": { "term" : -1, "transactionIndex" : 11 }TransactionIndex 11 increases from 9 is what we expect.