HDDS-6713. Avoid the need to cast to MiniOzoneHAClusterImpl #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
test
code-cleanup
aswinshakil
approved these changes
Feb 29, 2024
|
LGTM +1 |
|
Thanks @aswinshakil, @Galsza for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
) (cherry picked from commit 804366a) Change-Id: Id63c2d6f54d551e0fc78ba52880a0ac91eee0f44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
MiniOzoneHAClusterImpl.Builder.build()returnMiniOzoneHAClusterImpl, so that tests do not need to cast the return value.https://issues.apache.org/jira/browse/HDDS-6713
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8083218045