Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10440. Set new cluster ID and config instance in MiniOzoneCluster#build() #6325

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

MiniOzoneCluster.Builder allows creating multiple cluster instances from the same builder. To avoid conflict, users (currently only MiniOzoneClusterProvider) need to set new cluster ID and a copy of the configuration. The goal of this change is to automatically set the cluster ID and config whenever build() is called.

https://issues.apache.org/jira/browse/HDDS-10440

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/8139597150

Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@nandakumar131 nandakumar131 merged commit f4ba2be into apache:master Mar 15, 2024
26 checks passed
@nandakumar131
Copy link
Contributor

Thanks @adoroszlai for the contribution!

@adoroszlai adoroszlai deleted the HDDS-10440 branch March 15, 2024 07:49
@adoroszlai
Copy link
Contributor Author

Thanks @nandakumar131 for reviewing and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants