HDDS-10487. Intermittent crash in TestSnapshotDiffManager #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
approved these changes
Mar 7, 2024
|
Thanks @hemantk-12 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix intermittent crash in
TestSnapshotDiffManager:SnapshotDiffManagerwithout closing the previous instance. Actually the new one seems to be unnecessary, as original one is created@BeforeEach.SnapshotDiffManagerbefore closing RocksDB objects.https://issues.apache.org/jira/browse/HDDS-10487
How was this patch tested?
No crash in 500 runs (but had 5 failures due to NPE, reported in HDDS-10490):
https://github.com/adoroszlai/ozone/actions/runs/8191095498
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/8191527914