HDDS-10546. OM startup failure as leader is not getting ready #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Mar 18, 2024
There was a problem hiding this comment.
@sumitagrawl , thanks for working on this! The change looks good. Just two minor comments inlined.
| // if newTermIndex getting updated is within sequence of notifiedTermIndex (i.e. from lastSkippedIndex and | ||
| // notifiedTermIndex), then can update directly to lastNotifiedTermIndex as it ensure previous double buffer's | ||
| // Index is notified or getting notified matching lastSkippedIndex | ||
| if (newTermIndex.getIndex() <= getLastNotifiedTermIndex().getIndex() |
| // notifiedTermIndex), then can update directly to lastNotifiedTermIndex as it ensure previous double buffer's | ||
| // Index is notified or getting notified matching lastSkippedIndex | ||
| if (newTermIndex.getIndex() <= getLastNotifiedTermIndex().getIndex() | ||
| && getLastAppliedTermIndex().getIndex() >= lastSkippedIndex) { |
There was a problem hiding this comment.
Don't call getLastAppliedTermIndex() twice, i.e.
@Override
protected synchronized boolean updateLastAppliedTermIndex(TermIndex newTermIndex) {
final TermIndex lastApplied = getLastAppliedTermIndex();
assertUpdateIncreasingly("lastApplied", lastApplied, newTermIndex);
// if newTermIndex getting updated is within sequence of notifiedTermIndex (i.e. from lastSkippedIndex and
// notifiedTermIndex), then can update directly to lastNotifiedTermIndex as it ensure previous double buffer's
// Index is notified or getting notified matching lastSkippedIndex
if (newTermIndex.getIndex() < getLastNotifiedTermIndex().getIndex()
&& lastApplied.getIndex() >= lastSkippedIndex) {
newTermIndex = getLastNotifiedTermIndex();
}
return super.updateLastAppliedTermIndex(newTermIndex);
}
szetszwo
approved these changes
Mar 18, 2024
|
@sumitagrawl Thanks for the patch, @szetszwo for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OM is not getting stopped even after Leader is elected but Leader is not ready. This is an impact of HDDS-10026.
As solution, need update lastAppliedTransactionId with notifiedIndex if that is in sequence. So that Ratis can also get latest sequenceId as updated.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10546
How was this patch tested?