Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10309. Speed up TestSnapshotDeletingService #6541

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

raju-balpande
Copy link
Contributor

@raju-balpande raju-balpande commented Apr 16, 2024

What changes were proposed in this pull request?

Speed up TestSnapshotDeletingService
The time span is improved to 250.118 seconds from 321.147 seconds earlier.
https://github.com/raju-balpande/apache_ozone/actions/runs/8339044173/job/22820842037

Please describe your PR in detail:
We have managed the cluster creation part to be executed once.
What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10309?
How was this patch tested?

Tested each method independently and in sequence locally and Tested the sequence in Ci

Note:

I recreated this pull request to solve some of conflicts that the original file got replaced to a package and wasn't allowing to fix the conflicts. I recreated the branch and cherry-picked my changes. the earlier pull request was #6403

@hemantk-12 hemantk-12 added test snapshot https://issues.apache.org/jira/browse/HDDS-6517 labels Apr 16, 2024
Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raju-balpande for the patch.

LGTM.

@raju-balpande
Copy link
Contributor Author

Thanks @hemantk-12 , Can you please add second reviewer or how can this be merged.

@hemantk-12 hemantk-12 merged commit 4b8871f into apache:master Apr 17, 2024
31 checks passed
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
snapshot https://issues.apache.org/jira/browse/HDDS-6517 test
Projects
None yet
2 participants