HDDS-3142. Create isolated enviornment for OM to test it without SCM. #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2020
adoroszlai
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Thanks @elek for working on this. Tested, works well.
Would be nice to include mock-scm.btm script in hadoop-ozone/dist/target for testing.
...ds/common/src/main/java/org/apache/hadoop/hdds/freon/FakeScmBlockLocationProtocolClient.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/hadoop/hdds/freon/FakeScmContainerLocationProtocolClient.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/freon/FakeClusterTopology.java
Outdated
Show resolved
Hide resolved
|
Thanks the review @adoroszlai, I fixed the typo bugs.
100% agree. I created an issue to track this: https://issues.apache.org/jira/browse/HDDS-3232 |
|
Thanks @elek for updating the patch. |
elek
added a commit
that referenced
this pull request
Mar 24, 2020
isahkemat
pushed a commit
to isahkemat/hadoop-ozone
that referenced
this pull request
Mar 29, 2020
…out SCM. (apache#656)" This reverts commit 281faf3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OmKeyGeneratorclass from Freon can generate keys (open key + commit key). But this test tests both OM and SCM performance. It seems to be useful to have a method to test only the OM performance with faking the response from SCM.Can be done easily with the same approach what we have in HDDS-3023: A simple utility class can be implemented and with byteman we can replace the client calls with the fake method.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3142
How was this patch tested?
ozone om --init+ozone om) with the following JVM parameters: (change the path)ozone freon omkgExpected result: It should be possible to init and start OM without SCM and test it with the key generator)