Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-9679. Added Multipart Upload ID to S3MultiPart audit logs. #6677

Merged
merged 2 commits into from
May 15, 2024

Conversation

SaketaChalamchala
Copy link
Contributor

What changes were proposed in this pull request?

Multipart UploadID is not written to S3 MPU requests. Since, the same multipart key can be created with multiple uploadIDs added the multipart UploadID info to the audits.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9679

How was this patch tested?

Manually tested multipart commands using aws s3api

2024-05-14 00:33:50,810 | INFO  | S3GAudit | user=unsecure | ip=172.19.0.3 | op=INIT_MULTIPART_UPLOAD {bucket=[testbucket], path=[large_test_file1], uploads=[]} | ret=SUCCESS |  
2024-05-14 00:34:36,473 | INFO  | S3GAudit | user=unsecure | ip=172.19.0.3 | op=CREATE_MULTIPART_KEY {bucket=[testbucket], path=[large_test_file1], uploadId=[57bc370c-e8c5-4a24-b7ec-2a1e4b3a240f-112436630703439875], partNumber=[1]} | ret=SUCCESS | perf={streamMode=true, metaLatencyMs=29, sizeByte=5242880, opLatencyMs=793} |  
2024-05-14 00:34:49,372 | INFO  | S3GAudit | user=unsecure | ip=172.19.0.3 | op=CREATE_MULTIPART_KEY {bucket=[testbucket], path=[large_test_file1], uploadId=[57bc370c-e8c5-4a24-b7ec-2a1e4b3a240f-112436630703439875], partNumber=[2]} | ret=SUCCESS | perf={streamMode=true, metaLatencyMs=9, sizeByte=5242880, opLatencyMs=376} |  
2024-05-14 00:36:03,031 | INFO  | S3GAudit | user=unsecure | ip=172.19.0.3 | op=LIST_PARTS {bucket=[testbucket], path=[large_test_file1], uploadId=[57bc370c-e8c5-4a24-b7ec-2a1e4b3a240f-112436630703439875]} | ret=SUCCESS | perf={count=2, opLatencyMs=19} |  
2024-05-14 00:37:09,408 | INFO  | S3GAudit | user=unsecure | ip=172.19.0.3 | op=COMPLETE_MULTIPART_UPLOAD {bucket=[testbucket], path=[large_test_file1], uploadId=[57bc370c-e8c5-4a24-b7ec-2a1e4b3a240f-112436630703439875]} | ret=SUCCESS | 

@SaketaChalamchala
Copy link
Contributor Author

@ivandika3 can you please take a look at this?

Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improvement. LGTM +1.

Let's wait for a clean CI.

@ivandika3 ivandika3 merged commit a87c539 into apache:master May 15, 2024
39 checks passed
@ivandika3
Copy link
Contributor

Thank you @SaketaChalamchala for the patch and @kerneltime for the review.

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants