Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-11002. Speed up TestPipelineClose #6804

Merged
merged 1 commit into from
Jun 12, 2024
Merged

HDDS-11002. Speed up TestPipelineClose #6804

merged 1 commit into from
Jun 12, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Speed up TestPipelineClose by reusing the same cluster for all test cases.

https://issues.apache.org/jira/browse/HDDS-11002

How was this patch tested?

Before:

[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 78.613 s - in org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithPipelineAction  Time elapsed: 26.663 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithOpenContainer  Time elapsed: 17.085 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithClosedContainer  Time elapsed: 16.943 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithLogFailure  Time elapsed: 17.901 s

After:

[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.547 s - in org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithPipelineAction  Time elapsed: 5.53 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithOpenContainer  Time elapsed: 0.003 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithClosedContainer  Time elapsed: 6.646 s
[INFO] org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose.testPipelineCloseWithLogFailure  Time elapsed: 8.711 s

CI:
https://github.com/adoroszlai/ozone/actions/runs/9471526718

@adoroszlai adoroszlai self-assigned this Jun 11, 2024
smengcl
smengcl approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adoroszlai adoroszlai merged commit 1550621 into apache:master Jun 12, 2024
28 checks passed
@adoroszlai adoroszlai deleted the HDDS-11002 branch June 12, 2024 08:15
@adoroszlai
Copy link
Contributor Author

Thanks @smengcl for the review.

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jun 17, 2024
@adoroszlai @jojochuang
HDDS-11002. Speed up TestPipelineClose (apache#6804)
0499777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smengcl smengcl smengcl approved these changes

Assignees

@adoroszlai adoroszlai

Labels
test
Projects
None yet
Milestone
No milestone
2 participants
@adoroszlai @smengcl