-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11057. Enable reproducible builds #6856
base: master
Are you sure you want to change the base?
Conversation
BASE_DIR="$(pwd -P)" | ||
REPORT_DIR=${OUTPUT_DIR:-"${BASE_DIR}/target/repro"} | ||
|
||
source "${DIR}"/_build.sh verify artifact:compare "$@" | tee "${REPORT_DIR}/output.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure which is the source artifacts used to validate reproducible builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is the source artifacts used to validate reproducible builds
The jars created and uploaded by build
check.
Build user and time is accessed in ozone/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/VersionInfo.java Lines 72 to 78 in 7df3120
and reported in ozone/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/util/OzoneVersionInfo.java Lines 72 to 73 in 7df3120
I plan to remove that, too, but the method which creates the version output string is being refactored in #6876. |
What changes were proposed in this pull request?
project.build.outputTimestamp
property.repro
to verify jars created bybuild
check.(This is only the first step in making all Ozone build artifacts reproducible.)
https://issues.apache.org/jira/browse/HDDS-11057
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/9634357696