Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3236. Fix Dropwizard metrics mapping for latest Ratis metrics. #707

Closed
wants to merge 5 commits into from

Conversation

elek
Copy link
Member

@elek elek commented Mar 23, 2020

What changes were proposed in this pull request?

Ratis use dropwizard metrics where the key parameters of the metrics (like group name or instance id) are part of the name of the metrics instead of using a tag.

For example

ratis.log_appender.851cb00a-af97-455a-b079-d94a77d2a936@group-C14654DE8C2C.follower_65f881ea-8794-403d-be77-a030ed79c341_match_index 

Instead of

ratis.log_appender_match_index{group="group-C14654DE8C2C",...} 

It makes hard to combine the same metrics (match_index) from different sources.

HDDS-2950 implemented a regexp based workaround, but the regexp doesn't match for the latest Ratis metrics.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3236

How was this patch tested?

Tested with kubernetes cluster generation ~200M keys.

An easier way to test is to start a docker compose cluster and check the /prom endpoint of one datanode:

docker-compose exec datanoe bash
curl localhost:9882/prom | grep index

@avijayanhwx
Copy link
Contributor

LGTM +1.

@bharatviswa504
Copy link
Contributor

Hi @elek Still I don't see a few of the ratis metrics.

Like numRetryCacheHits, numRequestQueueLimitHits and leaderNumResourceLimitHits

@elek
Copy link
Member Author

elek commented Mar 30, 2020

numRetryCacheHits, numRequestQueueLimitHits and leaderNumResourceLimitHits

These (*Hits) are implemented on Ratis side in a way that you can see them only if they have non-zero values.

Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@elek elek closed this in 18577a9 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants