HDDS-3236. Fix Dropwizard metrics mapping for latest Ratis metrics. #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ratis use dropwizard metrics where the key parameters of the metrics (like group name or instance id) are part of the name of the metrics instead of using a tag.
For example
Instead of
It makes hard to combine the same metrics (match_index) from different sources.
HDDS-2950 implemented a regexp based workaround, but the regexp doesn't match for the latest Ratis metrics.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3236
How was this patch tested?
Tested with kubernetes cluster generation ~200M keys.
An easier way to test is to start a docker compose cluster and check the
/prom
endpoint of one datanode: