Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3164. Add Recon endpoint to serve missing containers and its metadata. #714

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

vivekratnavel
Copy link
Contributor

What changes were proposed in this pull request?

  • Add an endpoint (/api/v1/containers/missing) to serve missing containers response
  • Add unit tests

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3164

How was this patch tested?

  • Unit test
  • Manual test:
    • Bring ozone via docker compose
    • Add random keys with RATIS factor ONE using freon (ozone freon rk --replicationType=RATIS --numOfVolumes=10 --numOfBuckets=10 --numOfKeys=10 --factor=ONE --numOfThreads=20)
    • Bring down one datanode
    • After 10m, the datanode should be reported as dead in Recon and the next run of MissingContainerTask should catch the missing containers in the dead datanode.

@vivekratnavel
Copy link
Contributor Author

@avijayanhwx @elek Please review

Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Minor comments inline.

@vivekratnavel
Copy link
Contributor Author

Acceptance test failure is not related to the change. It fails due to no space available on disk

Failing this attempt.Diagnostics: [2020-03-25 11:34:00.461]No space available in any of the local directories.

@avijayanhwx
Copy link
Contributor

Thank you for the contribution @vivekratnavel.

@avijayanhwx avijayanhwx merged commit 4682bab into apache:master Mar 25, 2020
@elek
Copy link
Member

elek commented Mar 27, 2020

If you see a flaky test, please disable it (without and issue) + create a new open issue and repeat the build. There is some risk that one flakiness hides a other. Merging patches without green build makes harder to debug flaky tests.

isahkemat pushed a commit to isahkemat/hadoop-ozone that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants