HDDS-3273. getConf does not return all OM addresses. #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @xiaoyuyao / @bharatviswa504 for review. |
bharatviswa504
previously approved these changes
Mar 27, 2020
| for (String nodeId : getOMNodeIds(conf, serviceId)) { | ||
| String rpcAddr = getOmRpcAddress(conf, | ||
| addKeySuffixes(OZONE_OM_ADDRESS_KEY, serviceId, nodeId)); | ||
| if (rpcAddr != null) { |
There was a problem hiding this comment.
One minor comment. when for one of nodeId address is undefined, do we want to print "unknown address" instead of silently ignoring?
There was a problem hiding this comment.
Thanks, Bharat for review.
Actually I modeled the method based on getOmAddress() and return InetSocketAddress so cannot put random string in the map, I added a log message instead.
|
Thank You @swagle for the contribution. |
isahekmat
pushed a commit
to isahekmat/hadoop-ozone
that referenced
this pull request
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added a new utility method to return a list of addresses keyed by serviceId.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3273
How was this patch tested?
Added a unit test and verified via docker:
bash-4.2$ /opt/hadoop/bin/ozone getconf -ozonemanagers{omservice=[om1/172.22.0.6:9862, om2/172.22.0.4:9862, om3/172.22.0.2:9862]}bash-4.2$ /opt/hadoop/bin/ozone getconf -ozonemanagersom