Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-2294. Create a new HISTORY.md in the new repository. #764

Merged
merged 7 commits into from
Apr 10, 2020

Conversation

elek
Copy link
Member

@elek elek commented Apr 3, 2020

What changes were proposed in this pull request?

During the apache/hadoop.git --> apache/hadoop-ozone.git move we rewrote the (git) history to simplify the work. Unfortunately some of the early work of HDDS-7280 is not part of the hadoop-ozone repository just the hadoop repository. As it suggested by Anu Engineer, we can explain this in a separated file and show how the origin of Ozone can be found.

Note: I wrote it after the repository separation but forgot to create the PR. I just found this doc in my documents folder and found it today.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2294

How was this patch tested?

Read it, please.

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elek You must have some massive to-do list for Ozone that you end up finding these, which are otherwise lost in the past :)
Overall the documentation is very nice!
Recommended some minor changes inline.

HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
HISTORY.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for writing this. I started to write some grammar suggestions, but @dineshchitlangia beat me to it.

HISTORY.txt Show resolved Hide resolved
@elek
Copy link
Member Author

elek commented Apr 8, 2020

Thank you very much the proofreading @dineshchitlangia (and @adoroszlai). It's a big help for me.

I have to answers, all the other suggestions are applied.

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elek Overall LGTM, minor suggestions inline.

HISTORY.md Outdated Show resolved Hide resolved
HISTORY.md Outdated Show resolved Hide resolved
HISTORY.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Got a clean CI also, thanks @elek for the contribution, @adoroszlai for the review.

@dineshchitlangia dineshchitlangia merged commit 5d8be37 into apache:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants