-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-3093. Allow forced overwrite of local file #800
Conversation
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/GetKeyHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, comments added inline.
Thanks @xiaoyuyao for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @adoroszlai thanks for working on this, @xiaoyuyao thanks for reviewing.
Thanks @dineshchitlangia for reviewing and merging it. |
What changes were proposed in this pull request?
Add
-f
(--force
) flag forozone sh key get
, to allow force overwrite of local file. This is useful for testing:/dev/null
(which already exists), only to verify existence and checksum of the keyHash cannot be calculated for
/dev/null
.This PR is based on top of #775, so that one should be merged first. The only change here is 2ca1fe2.
https://issues.apache.org/jira/browse/HDDS-3093
How was this patch tested?
Added smoke test for overwrite case.