Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-3399. Update JaegerTracing #835

Closed
wants to merge 6 commits into from
Closed

HDDS-3399. Update JaegerTracing #835

wants to merge 6 commits into from

Conversation

elek
Copy link
Member

@elek elek commented Apr 16, 2020

What changes were proposed in this pull request?

We currently use JaegerTracing 0.34.0. The latest is 1.2.0. We are several versions behind and should update. Note this update requires the latest version fo OpenTracing and has several breaking changes.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3399

How was this patch tested?

cd hadoop-ozone/dist/target/ozone-..../compose/ozone
export COMPOSE_FILE=docker-compose.yaml:profiling.yaml:monitoring.yaml
export OZONE_REPLICATION_FACTOR=3
./run -d

Executed freon + s3 crete bucket commands

Traces were displayed in jaeger.

adoroszlai
adoroszlai requested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for working on this. I have tested a few operations using Freon, S3 gateway, Shell, S3 Shell. I have found that span.finish() is missing in 2 places, which breaks span hierarchy (eg. writechunk on datanode at root level, instead of under writechunk in freon). After adding the missing finish() calls, all traces looked good.

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java Outdated
Comment on lines 145 to 152
Span span = GlobalTracer.get()
.buildSpan(spanName).start();
try (Scope scope = GlobalTracer.get().activateSpan(span)) {
return supplier.get();
} catch (Exception ex) {
span.setTag("failed", true);
throw ex;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Span should be finished.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to test it @adoroszlai . I didn't notice any problem with the spans when I tested, but yes, it seems to be missing. Added them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ ozone s3 path asdf

master: s3shell_master
patch: s3shell_patch

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java Outdated Show resolved Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java Outdated Show resolved Hide resolved
@elek
Copy link
Member Author

elek commented Apr 21, 2020

Thanks the review @adoroszlai I am merging it now (rebased checked with CI and got green light).

@elek elek closed this in 2acd2b1 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elek @adoroszlai