Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-3393. Recon throws NPE in clusterState endpoint #854

Merged
merged 3 commits into from Apr 22, 2020

Conversation

vivekratnavel
Copy link
Contributor

What changes were proposed in this pull request?

  • Perform a null check on tables before calling getEstimatedKeyCount() on them.
  • Update mock api response to match the expected json structure.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3393

How was this patch tested?

Patch was tested with docker-compose and verified that there is no NPE thrown in Recon logs after hitting the clusterState endpoint before first snapshot from OM.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments. Overall LGTM

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@bharatviswa504 bharatviswa504 merged commit 00799c2 into apache:master Apr 22, 2020
@bharatviswa504
Copy link
Contributor

Thank You @vivekratnavel for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants