Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core]Support compiled class cache in CodeGenUtils #2976

Closed
wants to merge 2 commits into from
Closed

[Core]Support compiled class cache in CodeGenUtils #2976

wants to merge 2 commits into from

Conversation

xiangyuf
Copy link
Contributor

@xiangyuf xiangyuf commented Mar 8, 2024

Purpose

Linked issue: close #2955

Reuse the generated class in CodeGeneratorImpl to improve performance.

Tests

org.apache.paimon.codegen.CodeGeneratorCacheTest

API and Format

Documentation

@xiangyuf
Copy link
Contributor Author

xiangyuf commented Mar 8, 2024

Hi @JingsongLi , PTAL when you have time. Thx.

@xiangyuf
Copy link
Contributor Author

@FangYongs @liming30 Hi, would u kindly help review this pr?

JingsongLi
JingsongLi requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add cache to CodeGenUtils? In that way, we can cache generated Class.

paimon-codegen/src/main/java/org/apache/paimon/codegen/CodeGeneratorImpl.java Outdated Show resolved Hide resolved
@xiangyuf
Copy link
Contributor Author

Can you just add cache to CodeGenUtils? In that way, we can cache generated Class.

@JingsongLi Do you mean cache the instance directly?

@JingsongLi
Copy link
Contributor

JingsongLi commented Mar 13, 2024 •
edited

Can you just add cache to CodeGenUtils? In that way, we can cache generated Class.

@JingsongLi Do you mean cache the instance directly?

I mean compiled Class<T>.

@xiangyuf xiangyuf changed the title [Core]Support generatedClass cache in CodeGeneratorImpl [Core]Support compiled class cache in CodeGenUtils Mar 14, 2024
@JingsongLi
Copy link
Contributor

Please fix compile

JingsongLi pushed a commit to JingsongLi/paimon that referenced this pull request Mar 15, 2024
@xiangyuf @JingsongLi
[core] Support compiled class cache in CodeGenUtils
94baa69 
This closes apache#2976
@JingsongLi
Copy link
Contributor

merged in 4ec5806

Looks like your email (fengxiangyu.fxy@bytedance.com) is not bind to your github id.

@xiangyuf
Copy link
Contributor Author

xiangyuf commented Mar 15, 2024 •
edited

merged in 4ec5806

Looks like your email (fengxiangyu.fxy@bytedance.com) is not bind to your github id.

@JingsongLi Thx, I've fixed the email link issue.

zhu3pang pushed a commit to zhu3pang/incubator-paimon that referenced this pull request Mar 29, 2024
@xiangyuf @zhu3pang
[core] Support compiled class cache in CodeGenUtils
dd0ef63 
This closes apache#2976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi Awaiting requested review from JingsongLi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support compiled class cache in CodeGenUtils
2 participants
@xiangyuf @JingsongLi