Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

PARQUET-1148: Revert coverage changes from PARQUET-1038 #415

Closed
wants to merge 3 commits into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Oct 25, 2017

Will take a look to see if this fixes the coverage upload

cc @cpcloud

@cpcloud
Copy link
Contributor

cpcloud commented Oct 25, 2017

@wesm Thanks for doing this.

Are lines like these concerning?

File '/usr/include/c++/4.9/istream'
No executable lines
Removing 'decode_benchmark.cc.o##istream.gcov'

My original goal with that patch was to prevent coverage of std.

@wesm
Copy link
Member Author

wesm commented Oct 25, 2017

Yeah, you can see in this build on June 22 that things are pretty messed up:

https://coveralls.io/builds/12088976

It seems things are broken in numerous ways. After the changes in #357 coveralls no longer recognized anything from the coverage upload

@wesm
Copy link
Member Author

wesm commented Oct 25, 2017

Alright with the patch in the current state, nothing is showing up: https://coveralls.io/jobs/30578926

@wesm
Copy link
Member Author

wesm commented Oct 25, 2017

It looks like coveralls-lcov might save us here, since cpp_coveralls is super fickle. see example project:

https://github.com/kimkulling/openddl-parser/blob/master/.travis.yml

@wesm
Copy link
Member Author

wesm commented Aug 15, 2018

Closing. If we proceed with the monorepo initiative, then coverage will be taken care of pretty much automatically

@wesm wesm closed this Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants